meet: E2E test — Tier 1 hit → Tier 2 confirms → agent wake → meet_send_chat#25952
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be5593d25e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expect(blocks[0]!.name).toBe("meet_send_chat"); | ||
|
|
||
| // Performance envelope — comfortable headroom over the plan's 100ms. | ||
| expect(elapsedMs).toBeLessThan(100); |
There was a problem hiding this comment.
elapsedMs is measured with real time across async I/O (setTimeout, fetch, and Bun server scheduling), so this check can fail intermittently on slow or contended CI runners even when behavior is correct. That makes this new end-to-end test flaky and can block unrelated changes; prefer validating functional effects here and moving latency enforcement to a benchmark-style test with a looser percentile-based threshold.
Useful? React with 👍 / 👎.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Follow-up shipped in #26265 — addresses consolidated review feedback (chat concurrency mutex, dispose teardown, wake adapter timeout/ghost prevention, tokenEstimationProvider forwarding, E2E test flakiness). |
1 participant
Summary
Part of plan: meet-phase-2-chat.md (PR 8 of 8)