Skip to content

meet-bot: implement POST /send_chat endpoint#25941

Merged
siddseethepalli merged 1 commit into
mainfrom
run-plan/meet-phase-2-chat/pr-1
Apr 15, 2026
Merged

meet-bot: implement POST /send_chat endpoint#25941
siddseethepalli merged 1 commit into
mainfrom
run-plan/meet-phase-2-chat/pr-1

Conversation

@siddseethepalli
Copy link
Copy Markdown
Contributor

Summary

  • Replace 501 stub in bot HTTP server with real /send_chat handler
  • Validate body via SendChatCommand Zod; enforce 2000-char limit
  • Call sendChat helper from chat-bridge; return 200/400/401/502 as appropriate
  • Unit tests cover auth, validation, success, Playwright failure paths

Part of plan: meet-phase-2-chat.md (PR 1 of 8)

@siddseethepalli siddseethepalli merged commit 04bef0d into main Apr 15, 2026
@siddseethepalli siddseethepalli deleted the run-plan/meet-phase-2-chat/pr-1 branch April 15, 2026 22:43
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 41fa5b8c9a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +171 to +173
try {
await onSendChat(parsed.data.text);
} catch (err) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Serialize /send_chat requests before invoking onSendChat

/send_chat handlers run concurrently, but they all drive the same Meet chat input on a single Playwright page. If two authenticated requests overlap, one call can fill() over the other's text before press("Enter"), causing the wrong message to be sent (or sent twice) even though both HTTP requests may return success. Adding a per-server mutex/queue around onSendChat would make message delivery deterministic under parallel sends/retries.

Useful? React with 👍 / 👎.

@siddseethepalli
Copy link
Copy Markdown
Contributor Author

Follow-up shipped in #26265 — addresses consolidated review feedback (chat concurrency mutex, dispose teardown, wake adapter timeout/ghost prevention, tokenEstimationProvider forwarding, E2E test flakiness).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant