meet-bot: implement POST /send_chat endpoint#25941
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41fa5b8c9a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try { | ||
| await onSendChat(parsed.data.text); | ||
| } catch (err) { |
There was a problem hiding this comment.
Serialize /send_chat requests before invoking onSendChat
/send_chat handlers run concurrently, but they all drive the same Meet chat input on a single Playwright page. If two authenticated requests overlap, one call can fill() over the other's text before press("Enter"), causing the wrong message to be sent (or sent twice) even though both HTTP requests may return success. Adding a per-server mutex/queue around onSendChat would make message delivery deterministic under parallel sends/retries.
Useful? React with 👍 / 👎.
|
Follow-up shipped in #26265 — addresses consolidated review feedback (chat concurrency mutex, dispose teardown, wake adapter timeout/ghost prevention, tokenEstimationProvider forwarding, E2E test flakiness). |
Summary
Part of plan: meet-phase-2-chat.md (PR 1 of 8)