Skip to content

fix(tests): isolate encrypted store per test file #25717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddseethepalli merged 1 commit into from
Apr 15, 2026
Merged

fix(tests): isolate encrypted store per test file #25717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions assistant/src/__tests__/test-preload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { join } from "node:path";
import { afterAll } from "bun:test";

import { resetDb } from "../memory/db-connection.js";
import { _setStorePath } from "../security/encrypted-store.js";

const testDir = realpathSync(
mkdtempSync(join(tmpdir(), "vellum-test-workspace-")),
Expand All @@ -25,6 +26,11 @@ process.env.VELLUM_WORKSPACE_DIR = testDir;
process.env.VELLUM_PLATFORM_URL = "https://test-platform.vellum.ai";
process.exitCode = 0;

// Isolate the encrypted credential store per test file. Without this,
// parallel test processes all read/write the same ~/.vellum/protected/keys.enc,
// causing races when one file deletes a key while another sets it.
_setStorePath(join(testDir, "keys.enc"));

// Force-close any DB connection inherited from the parent process (e.g. when
// the test runner is spawned by the running assistant via a pre-push hook).
// Without this, the db singleton in db-connection.ts may still point at the
Expand Down
Loading