fix(macos): avoid O(n) hashing of tool output for NSCache key#25048
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4e471d1d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
siddseethepalli
added a commit
that referenced
this pull request
Apr 12, 2026
The cache key helper introduced in #25048 expects a String for toolCallID, but ToolCallData.id is a UUID. Use .uuidString to bridge the types and unbreak the macOS build + tests.
siddseethepalli
added a commit
that referenced
this pull request
Apr 12, 2026
The cache key helper introduced in #25048 expects a String for toolCallID, but ToolCallData.id is a UUID. Use .uuidString to bridge the types and unbreak the macOS build + tests.
2 tasks
Contributor
Author
|
Addressed in #25092 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Codex feedback on #24336 — cache key now derives from toolCall.id + result.count + error flag instead of hashing the full result string every render.