fix(macOS): coalesce composer menu refreshes and remove withAnimation wrappers#24337
Merged
Merged
Conversation
… wrappers Replace direct withAnimation(VAnimation.fast) wrappers on emoji/slash menu state toggles with a ComposerMenuRefreshScheduler that defers updates to the next run-loop tick. This coalesces rapid onChange firings (e.g. from inputText + cursorPosition changing together) into a single menu state update, eliminating redundant SwiftUI animation cycles and preventing potential layout thrash. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
noanflaherty
pushed a commit
that referenced
this pull request
Apr 8, 2026
… wrappers (#24337) Replace direct withAnimation(VAnimation.fast) wrappers on emoji/slash menu state toggles with a ComposerMenuRefreshScheduler that defers updates to the next run-loop tick. This coalesces rapid onChange firings (e.g. from inputText + cursorPosition changing together) into a single menu state update, eliminating redundant SwiftUI animation cycles and preventing potential layout thrash. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComposerMenuRefreshSchedulerto coalesce rapidonChangefirings into a single deferred menu-state update, eliminating redundant work wheninputTextandcursorPositionchange togetherwithAnimation(VAnimation.fast)wrappers from emoji picker and slash command menu state toggles — the animations were causing layout thrash and are no longer needed with the coalesced scheduler.animation(VAnimation.fast, value:)modifiers from the composer VStack since menu visibility changes are now immediate