Skip to content

chore(host-browser): Phase 2 polish + hardening (P3 cleanups)#24245

Merged
noanflaherty merged 1 commit into
mainfrom
do/host-browser-followup-b
Apr 8, 2026
Merged

chore(host-browser): Phase 2 polish + hardening (P3 cleanups)#24245
noanflaherty merged 1 commit into
mainfrom
do/host-browser-followup-b

Conversation

@noanflaherty
Copy link
Copy Markdown
Contributor

@noanflaherty noanflaherty commented Apr 8, 2026

Summary

  • Derive HOST_TOOL_NAMES from HOST_TOOL_TO_CAPABILITY so the invariant is structural
  • Delete dead chrome-extension wiring in handleConversationCreate (zero callers in production code)
  • Add explicit assert in prepareConversationForMessage to fail loudly if chrome-extension reaches it
  • Add tsc --noEmit step to chrome-extension build.sh so type errors are caught at build time
  • Tighten host-browser-routes.ts non-null assertion with an explicit guard + 400 response
  • Resolve chrome-extension registry guardianId at send-time from conversation.trustContext instead of captured per-POST authContext
  • Add parseHostHeader IPv6 edge-case unit tests (table-driven)
  • Add Phase 3 hand-off comments to verifyHostBrowserCapability and browser-session/index.ts

Addresses items 6-13 from the round-4 self-review of PR #24159.

Original prompt

one PR for items 1-5 and also /do in parallel another PR for items 6-13


Open with Devin

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread assistant/src/daemon/handlers/conversations.ts
@noanflaherty
Copy link
Copy Markdown
Contributor Author

@devin review this PR again — reply posted explaining that ConversationCreateRequest is intentionally retained as part of the wire protocol (actively used by Swift clients). The observation-only thread has been resolved. No code fixes needed.

@noanflaherty noanflaherty merged commit ec2a962 into main Apr 8, 2026
12 checks passed
@noanflaherty noanflaherty deleted the do/host-browser-followup-b branch April 8, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant