Skip to content

chore(chrome-extension): tighten bun:test shim so only test.todo has optional callback #24234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noanflaherty merged 1 commit into from
Apr 8, 2026
Merged

chore(chrome-extension): tighten bun:test shim so only test.todo has optional callback #24234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions clients/chrome-extension/types/bun-test-shim.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,22 @@

declare module 'bun:test' {
type TestCallback = () => void | Promise<void>;
type TestFn = (name: string, fn?: TestCallback) => void;

interface TestApi extends TestFn {
todo: TestFn;
skip: TestFn;
only: TestFn;
/** Runnable test: body is required. Applies to test(), test.skip(), test.only(). */
type RunnableTestFn = (name: string, fn: TestCallback) => void;

/** Permissive variant for test.todo — a body is optional because
* a todo can declare intent to write a test in the future. */
type TodoTestFn = (name: string, fn?: TestCallback) => void;

interface TestApi extends RunnableTestFn {
/** Mark a test as a TODO — reports as 'todo' rather than 'passed'.
* Use for planned tests that haven't been written yet. */
todo: TodoTestFn;
/** Skip a test temporarily. Use sparingly; prefer removing or fixing. */
skip: RunnableTestFn;
/** Run only this test. Do not commit .only() calls. */
only: RunnableTestFn;
}

interface DescribeApi {
Expand Down