Skip to content

chore(daemon): rewrite host-tool gating test comment in forward-looking voice #24233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noanflaherty merged 1 commit into from
Apr 8, 2026
Merged

chore(daemon): rewrite host-tool gating test comment in forward-looking voice #24233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions assistant/src/daemon/__tests__/conversation-tool-setup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@
* `hasNoClient: true` continues to deny all host tools on macos.
*
* The per-capability check (`supportsHostProxy(transport, capability)`) runs
* first and is authoritative for structural support, so host_bash/host_file_*
* remain filtered out for chrome-extension (Codex P1 leak stays plugged).
* first and is authoritative for structural support, so host_bash and
* host_file_* are filtered out for chrome-extension regardless of the
* hasNoClient flag.
*/

import { describe, expect, test } from "bun:test";
Expand Down Expand Up @@ -88,13 +89,12 @@ describe("isToolActiveForContext — host tool capability gating", () => {
});

// chrome-extension transport: the extension is its own executor.
test("host_browser is active for chrome-extension when hasNoClient is true (regression fix)", () => {
// Regression coverage for PR #24195: the per-capability tool gate was
// previously placed inside the `hasNoClient` short-circuit, which
// filtered `host_browser` out for chrome-extension turns (which run
// with `hasNoClient: true` by design). The extension is its own
// executor and gates commands via its own popup UI, so it must be
// exempt from the hasNoClient gate.
test("host_browser is active for chrome-extension even when hasNoClient is true", () => {
// chrome-extension turns run with `hasNoClient: true` by design because
// chrome-extension is not in `INTERACTIVE_INTERFACES` — it is not an
// SSE interactive channel. The extension gates host_browser commands
// via its own popup UI, so the hasNoClient gate must not filter
// host_browser out for chrome-extension transports.
expect(
isToolActiveForContext(
"host_browser",
Expand All @@ -118,9 +118,9 @@ describe("isToolActiveForContext — host tool capability gating", () => {
).toBe(true);
});

test("host_bash is NOT active for chrome-extension even when hasNoClient is true (Codex P1 leak)", () => {
test("host_bash is NOT active for chrome-extension even when hasNoClient is true", () => {
// The per-capability check runs first and is authoritative: chrome-extension
// only supports `host_browser`, so `host_bash` must remain filtered out.
// only supports `host_browser`, so `host_bash` must be filtered out.
expect(
isToolActiveForContext(
"host_bash",
Expand Down
Loading