Skip to content

[LUM-718] perf: flatten inner view hierarchies (MarkdownSegmentView, AssistantProgressView) #23982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jasonnnz merged 4 commits into from
Apr 8, 2026
Merged

[LUM-718] perf: flatten inner view hierarchies (MarkdownSegmentView, AssistantProgressView) #23982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f325ec5
[LUM-718] perf: flatten inner view hierarchies to reduce layout depth
devin-ai-integration[bot] Apr 7, 2026
3148007
[LUM-718] Restore .clipShape() to prevent content overflow at rounded…
devin-ai-integration[bot] Apr 7, 2026
bf7c69b
[LUM-718] Separate stroke into overlay to prevent clipping
devin-ai-integration[bot] Apr 7, 2026
19cee44
[LUM-718] Add hit testing and accessibility guards to opacity-hidden …
devin-ai-integration[bot] Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 34 additions & 37 deletions clients/macos/vellum-assistant/Features/Chat/AssistantProgressView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,13 +901,11 @@ private struct StepDetailRow: View {
}

// Title (reason-first, then skillLabel for skill_execute, then fallback)
VStack(alignment: .leading, spacing: VSpacing.xxs) {
Text(stepTitle)
.font(VFont.labelDefault)
.foregroundStyle(stepTitleColor)
.lineLimit(1)
.truncationMode(.tail)
}
Text(stepTitle)
.font(VFont.labelDefault)
.foregroundStyle(stepTitleColor)
.lineLimit(1)
.truncationMode(.tail)

Spacer()

Expand Down Expand Up @@ -970,23 +968,21 @@ private struct StepDetailRow: View {
.foregroundStyle(VColor.contentTertiary)
.textCase(.uppercase)

VStack(alignment: .leading, spacing: VSpacing.xs) {
if let reason = toolCall.reasonDescription, !reason.isEmpty {
Text(toolCall.actionDescription)
.font(VFont.labelDefault)
.foregroundStyle(VColor.contentSecondary)
}
Text(toolCall.friendlyName)
if let reason = toolCall.reasonDescription, !reason.isEmpty {
Text(toolCall.actionDescription)
.font(VFont.labelDefault)
.foregroundStyle(VColor.contentSecondary)
if !resolvedInputFull.isEmpty {
outputBlock(
text: resolvedInputFull,
attributedText: nil,
copyText: resolvedInputFull,
copyLabel: "Copy input"
)
}
}
Text(toolCall.friendlyName)
.font(VFont.labelDefault)
.foregroundStyle(VColor.contentSecondary)
if !resolvedInputFull.isEmpty {
outputBlock(
text: resolvedInputFull,
attributedText: nil,
copyText: resolvedInputFull,
copyLabel: "Copy input"
)
}
}
.padding(.horizontal, VSpacing.lg)
Expand Down Expand Up @@ -1054,7 +1050,10 @@ private struct StepDetailRow: View {
outputTextView(text: text, attributedText: attributedText, isError: isError)
.padding(EdgeInsets(top: VSpacing.sm, leading: VSpacing.sm, bottom: VSpacing.sm, trailing: VSpacing.sm + VSpacing.xl))
.frame(maxWidth: .infinity, alignment: .leading)
.background(VColor.surfaceOverlay.opacity(0.6))
.background(
RoundedRectangle(cornerRadius: VRadius.sm)
.fill(VColor.surfaceOverlay.opacity(0.6))
)
.clipShape(RoundedRectangle(cornerRadius: VRadius.sm))
.overlay(
RoundedRectangle(cornerRadius: VRadius.sm)
Expand Down Expand Up @@ -1168,20 +1167,18 @@ private struct CompactPermissionChip: View {

var body: some View {
HStack(spacing: VSpacing.xxs) {
Group {
switch state {
case .approved:
VIconView(.circleCheck, size: 10)
.foregroundStyle(chipColor)
case .denied:
VIconView(.circleAlert, size: 10)
.foregroundStyle(chipColor)
case .timedOut:
VIconView(.clock, size: 10)
.foregroundStyle(chipColor)
default:
EmptyView()
}
switch state {
case .approved:
VIconView(.circleCheck, size: 10)
.foregroundStyle(chipColor)
case .denied:
VIconView(.circleAlert, size: 10)
.foregroundStyle(chipColor)
case .timedOut:
VIconView(.clock, size: 10)
.foregroundStyle(chipColor)
default:
EmptyView()
}

Text(state == .approved || state == .denied ? label : "Timed Out")
Expand Down
36 changes: 16 additions & 20 deletions clients/macos/vellum-assistant/Features/Chat/ChatBubbleToolStatusView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,12 @@ extension ChatBubble {
inlineToolCallImages(from: message.toolCalls)
} else if !effectiveConfirmations.isEmpty, !inlineToolProgressRenderedInContent {
// No tool display needed — only show permission chips.
VStack(alignment: .leading, spacing: 0) {
HStack(alignment: .center, spacing: VSpacing.sm) {
ForEach(Array(effectiveConfirmations.enumerated()), id: \.offset) { _, confirmation in
compactPermissionChip(confirmation)
}
Spacer()
HStack(alignment: .center, spacing: VSpacing.sm) {
ForEach(Array(effectiveConfirmations.enumerated()), id: \.offset) { _, confirmation in
compactPermissionChip(confirmation)
}
}
.frame(maxWidth: .infinity, alignment: .leading)
.padding(.top, VSpacing.xxs)
}
}
Expand All @@ -86,20 +84,18 @@ extension ChatBubble {
let chipColor: Color = isApproved ? VColor.primaryBase : isDenied ? VColor.systemNegativeStrong : VColor.contentTertiary

return HStack(spacing: VSpacing.xs) {
Group {
switch confirmation.state {
case .approved:
VIconView(.circleCheck, size: 12)
.foregroundStyle(chipColor)
case .denied:
VIconView(.circleAlert, size: 12)
.foregroundStyle(chipColor)
case .timedOut:
VIconView(.clock, size: 12)
.foregroundStyle(chipColor)
default:
EmptyView()
}
switch confirmation.state {
case .approved:
VIconView(.circleCheck, size: 12)
.foregroundStyle(chipColor)
case .denied:
VIconView(.circleAlert, size: 12)
.foregroundStyle(chipColor)
case .timedOut:
VIconView(.clock, size: 12)
.foregroundStyle(chipColor)
default:
EmptyView()
}

Text(isApproved || isDenied ? "\(confirmation.toolCategory)" :
Expand Down
7 changes: 5 additions & 2 deletions clients/macos/vellum-assistant/Features/Chat/MarkdownSegmentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,10 +826,11 @@ private struct CodeBlockView: View, Equatable {
Spacer()
VCopyButton(text: code, size: .compact)
.opacity(isHovered ? 1 : 0)
.allowsHitTesting(isHovered)
.accessibilityHidden(!isHovered)
.animation(VAnimation.fast, value: isHovered)
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
}
.padding(.horizontal, VSpacing.sm)
.padding(.top, VSpacing.xs)
.padding(EdgeInsets(top: VSpacing.xs, leading: VSpacing.sm, bottom: 0, trailing: VSpacing.sm))
}

let codeLineCount = code.utf8.reduce(1) { $0 + ($1 == 0x0A ? 1 : 0) }
Expand Down Expand Up @@ -869,6 +870,8 @@ private struct CodeBlockView: View, Equatable {
if language == nil || language?.isEmpty == true {
VCopyButton(text: code, size: .compact)
.opacity(isHovered ? 1 : 0)
.allowsHitTesting(isHovered)
.accessibilityHidden(!isHovered)
.animation(VAnimation.fast, value: isHovered)
.padding(VSpacing.xs)
}
Expand Down