fix(attachments): address PR #2285 feedback — ordering, fast-deny, run scoping#2306
Merged
Conversation
…n scoping 1. Move setAssistantId() after isProcessing() check in both persistAndProcessMessage and processMessage to prevent mid-flight assistantId mutation when a concurrent request is rejected. 2. Add hasNoClient flag to Session so approveHostAttachmentRead can fail fast for HTTP-created sessions instead of blocking for the full permission timeout with no client to respond. 3. Call session.setAssistantId(assistantId) in RunOrchestrator.startRun so run-generated attachments are scoped to the correct assistant instead of falling back to 'local-assistant'. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5948341b87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
|
Addressed in #2330 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses three review comments from PR #2285:
setAssistantId()afterisProcessing()check inpersistAndProcessMessageandprocessMessageso a rejected concurrent request doesn't mutate the assistantId visible to an in-flight request.hasNoClientflag to Session soapproveHostAttachmentReadcan deny immediately for HTTP-created sessions instead of blocking for the full permission timeout (300s) with no client to respond.session.setAssistantId(assistantId)inRunOrchestrator.startRunso run-generated attachments are stored under the correct assistant ID instead of falling back to'local-assistant'.Test plan
/runsendpoint are scoped to the correct assistant