fix: pass messageId in iOS lifecycle tests to match message_complete guard#23053
Merged
Conversation
…guard The guard added in f97ad8a skips message_complete events without messageId while isSending is true. These two tests send messages then call MessageCompleteMessage() without a messageId, causing the handler to no-op. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
siddseethepalli
added a commit
that referenced
this pull request
Apr 2, 2026
…ete guard The message_complete guard (ChatActionHandler:355) returns early when messageId is nil and isSending is true, preventing state cleanup. Tests were constructing MessageCompleteMessage() without a messageId, triggering the guard and causing XCTAssertFalse failures. Same fix pattern as #23053 which addressed ConversationLifecycleIOSTests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
siddseethepalli
added a commit
that referenced
this pull request
Apr 2, 2026
…ete guard (#23059) The message_complete guard (ChatActionHandler:355) returns early when messageId is nil and isSending is true, preventing state cleanup. Tests were constructing MessageCompleteMessage() without a messageId, triggering the guard and causing XCTAssertFalse failures. Same fix pattern as #23053 which addressed ConversationLifecycleIOSTests. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testNewConversationReceivesAndCompletesMessages,testMultipleMessagesInSameConversation) were failing because the guard added in fix: guard against auxiliary message_complete clearing turn state #23049 skipsmessage_completeevents withoutmessageIdwhileisSendingis truemessageIdin testMessageCompleteMessage()calls to match real backend behavior (which now includesmessageIdper fix: include messageId in notifier message_complete events #23048)Original prompt
--yolo Fix the specific CI issue in this failing job only: https://github.com/vellum-ai/vellum-assistant/actions/runs/23878739463/job/69627346840