Skip to content

Revert "Move network layer off @MainActor isolation (#21695)"#21711

Merged
ashleeradka merged 1 commit into
mainfrom
devin/1774542875-revert-21695
Mar 26, 2026
Merged

Revert "Move network layer off @MainActor isolation (#21695)"#21711
ashleeradka merged 1 commit into
mainfrom
devin/1774542875-revert-21695

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Mar 26, 2026

Summary

Reverts PR #21695 which removed @MainActor from the network client layer. After merging to main, the app hangs immediately on launch. This revert restores the original @MainActor annotations to unblock development while the root cause is investigated.

What this restores:

  • @MainActor on GatewayHTTPClient, HealthCheckClient, HostToolExecutor static methods, and ~40 network client protocols/structs
  • Task { @MainActor in in BtwClient.sendMessage() (was changed to Task {)
  • Synchronous resolveConnection(), isConnectionManaged(), buildURL() (were made async in the fix-up commit)
  • Synchronous handleAuthenticationFailure() in GatewayConnectionManager and approvalPath() in InteractionClient

Context: The original PR also coincided with PR #21696 (SettingsStore/SigningIdentityManager changes). The hang could be from either PR or their interaction. This revert isolates #21695 to determine the cause.

Review & Testing Checklist for Human

Notes

  • This was a clean git revert with no merge conflicts despite intervening commits
  • The @MainActor removal will be re-attempted in a future PR with more careful testing of the startup path and actor-hopping behavior, particularly the interaction between GatewayConnectionManager (MainActor) → resolveConnection() (nonisolated async) → AuthService.shared.baseURL (MainActor)

Link to Devin session: https://app.devin.ai/sessions/e19a9c46f61546368efaba6020397e17
Requested by: @ashleeradka


Open with Devin

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Copy Markdown
Contributor Author

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant