Replace daemon restart with resilient Qdrant collection recovery#1911
Merged
Conversation
Instead of restarting the entire daemon after `sessions clear` deletes the Qdrant collection, make VellumQdrantClient self-healing: detect "collection not found" errors, reset the collectionReady flag, and retry the operation. This avoids the production-impacting issue where restarting via stopDaemon()/startDaemon() relaunches the daemon with the CLI process's environment instead of the original daemon context, silently changing behavior-affecting env vars like QDRANT_URL and RUNTIME_HTTP_PORT. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0d841f605
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
2 tasks
Contributor
Author
|
Addressed in #1916 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sessions clearthat was introduced in PR Restart daemon after sessions clear to reset Qdrant state #1900VellumQdrantClientself-healing: when a Qdrant operation fails with a "collection not found" error (e.g. after external deletion), it resetscollectionReady, re-creates the collection viaensureCollection(), and retries the operationstopDaemon()/startDaemon()relaunches the daemon with the CLI process's environment, silently changing behavior-affecting env vars likeQDRANT_URLandRUNTIME_HTTP_PORTTest plan
vellum sessions clearwhile daemon is running — daemon should NOT restart, and subsequent memory operations should auto-recover by recreating the collectionvellum sessions clearwhile daemon is NOT running — no error, collection deleted normallyQDRANT_URLare preserved (no daemon restart means no env change)Addresses review feedback on #1900.