Fix hasExpandableContent to check cachedImage instead of imageData#1908
Merged
Conversation
hasExpandableContent was checking toolCall.imageData != nil, but the actual rendering uses toolCall.cachedImage. If imageData contains invalid base64, cachedImage would be nil while imageData is non-nil, causing an expandable chip with no visible content when expanded. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistency in
ToolCallChip.hasExpandableContentflagged by Devin review on PR #1905.hasExpandableContentwas checkingtoolCall.imageData != nil, but the actual rendering (line 66) usestoolCall.cachedImageimageDatacontains invalid base64,cachedImagewould benilwhileimageDatais non-nil, showing a chevron for an empty expandable areatoolCall.cachedImage != nilto stay consistent with what actually rendersTest plan