-
Notifications
You must be signed in to change notification settings - Fork 80
fix: use checkbox instead of toggle for ToS consent #18014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
77dd82f
fix: use checkbox instead of toggle for ToS consent in onboarding
tkheyfets 0ff8eb8
fix: add accessibility label and use VSpacing.xxs token for checkbox …
tkheyfets 57ef9cc
fix: style checkbox with V* design tokens, move to right, match secti…
tkheyfets eec66d9
fix: move checkbox to left side and make consent label semibold
tkheyfets 53245e3
fix: make ToS section full-width to match other sections
tkheyfets a25f347
fix: make unchecked checkbox tappable by adding contentShape and clea…
tkheyfets 9a31454
fix: revert consent text to regular weight
tkheyfets 49e5d49
fix: use VIconView for checkmark and .isToggle accessibility trait
tkheyfets 04e72dc
fix: add accessibilityValue to VCheckbox for dynamic state reporting
tkheyfets File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.