chore: remove registerComputerUseActionTools()#16598
Merged
siddseethepalli merged 1 commit intoMar 14, 2026
Merged
Conversation
…/registry.ts Computer-use tools are provided by the bundled skill. This function only existed for backward compat in tests — inline the registration directly. Co-Authored-By: Claude <noreply@anthropic.com>
siddseethepalli
deleted the
do/remove-register-computer-use-action-tools
branch
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
dvargasfuertes
pushed a commit
that referenced
this pull request
May 28, 2026
…32365) * tools: drop executionMode from base-list dedup; owner is sufficient The filter at registry.ts:getAllToolDefinitions and tasks/tool-sanitizer.ts:getRegisteredToolNames was t.executionMode !== "proxy" && getToolOwner(t.name)?.kind !== "skill" Two clauses, one job: keep proxy/projection tools out of the base tool list so they don't double-up when a skill projects them. The first clause is redundant — every tool the LLM should NOT see by default is already excluded by the owner clause: - computer_use_*: not core-registered at all (#16598 removed registerComputerUseActionTools). They enter the registry only via registerSkillTools("computer-use", …) during skill projection, where their owner becomes {kind: "skill", id: "computer-use"} — owner-clause excludes them. - meet_*: registered via registerExternalTools with skill owner — owner-clause excludes them. - ui_show / ui_update / ui_dismiss: registered as core (no owner) → SHOULD appear in the base list. The old filter excluded them via executionMode, then conversation-tool-setup.buildToolDefinitions spliced them back in unconditionally. Net result identical. - app_open: same shape as ui_*. After this PR: - registry.ts:getAllToolDefinitions and tool-sanitizer.ts both filter on owner alone. - conversation-tool-setup.buildToolDefinitions stops splicing allUiSurfaceTools + coreAppProxyTools — they flow through getAllToolDefinitions naturally, identical final tool set. - registry.ts snapshot drops the vestigial allComputerUseTools.map entry from manifestToolNames (no-op since #16598). - registry.test.ts "core registry includes app_open proxy tool" flips its assertion to expect app_open in getAllToolDefinitions, which is the new (correct) behavior. executionMode stays on Tool definitions: it still drives dispatch routing via resolveExecutionTarget (host vs sandbox) and the tool-approval-handler proxyToolResolver gate. That role survives. This PR removes the field's secondary role as the base-list dedup flag — which is what PR #32362 had to rename to "projectedBySkill" to express. With this PR landed, that rename is no longer needed: the field can simply be deleted in the follow-up. ### AGENTS.md compliance - assistant/src/tools/AGENTS.md — no new tools added; refactor of existing registry/dispatch surface only. * address review feedback + fix CI review feedback: - delete redundant buildToolDefinitions() wrapper; replace 4 callers with direct getAllToolDefinitions() calls (conversation.ts, btw-routes.ts, + 2 test files). - delete historical comment about allComputerUseTools in registry.ts. ci fixes (both pre-existing on main from #32361): - add home/feed/query route-policy entry (settings.read), matching the POST endpoint introduced in #32361 but never registered. - regenerate openapi.yaml to include the new /v1/home/feed/query path (445 paths, 507 operations). --------- Co-authored-by: vellum-apollo-bot[bot] <242025090+vellum-apollo-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assistant/src/tools/computer-use/registry.ts— the sole export (registerComputerUseActionTools) was only used by testschecker.test.tsusingallComputerUseTools+registerToolregistry.test.tsthat validated the deleted functionOriginal prompt
Remove registerComputerUseActionTools() — tools/computer-use/registry.ts.
🤖 Generated with Claude Code