Skip to content

move CLI command files into cli/commands/ subdirectory#14209

Merged
noanflaherty merged 1 commit into
mainfrom
do/move-cli-commands
Mar 7, 2026
Merged

move CLI command files into cli/commands/ subdirectory#14209
noanflaherty merged 1 commit into
mainfrom
do/move-cli-commands

Conversation

@noanflaherty

@noanflaherty noanflaherty commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Moved 26 CLI command registration files from assistant/src/cli/ into assistant/src/cli/commands/ to separate command definitions from shared utilities and infrastructure
  • Updated all relative imports in moved files, program.ts, and 6 test files
  • No functional changes — pure file reorganization with import path updates

Original prompt

Help me move all of these files into assistant/src/cli/commands so that all remaining files in assistant/src/cli are more like utility functions, and other things, not commands that need registering.

Generated with Claude Code


Open with Devin

Move all 26 command registration files from assistant/src/cli/ into
assistant/src/cli/commands/ so that cli/ contains only utilities,
infrastructure, and entry points (program.ts, utils.ts, reference.ts,
ipc-client.ts, email-guardrails.ts, main-screen.tsx).

Update all relative imports in moved files (../X → ../../X, ./utils →
../utils), program.ts imports (./X → ./commands/X), and 6 test files
that imported command modules directly.

Co-Authored-By: Claude <noreply@anthropic.com>
@noanflaherty noanflaherty merged commit 11d717b into main Mar 7, 2026
@noanflaherty noanflaherty deleted the do/move-cli-commands branch March 7, 2026 23:05

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 4 potential issues.

View 3 additional findings in Devin Review.

Open in Devin Review

Comment thread assistant/src/cli/commands/dev.ts
Comment thread assistant/src/cli/commands/dev.ts
Comment thread assistant/src/cli/commands/skills.ts
Comment thread assistant/src/cli/commands/doctor.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

const mainPath = `${import.meta.dirname}/../daemon/main.ts`;

P1 Badge Point dev launcher to daemon main entry

After moving this file into cli/commands, import.meta.dirname is one directory deeper, so ../daemon/main.ts now resolves to assistant/src/cli/daemon/main.ts (which does not exist). That makes assistant dev (with or without --watch) fail when it tries to spawn bun run against the wrong script path, so the dev command no longer starts the assistant.


let fullPath = `${dir}/../../node_modules/${wasm.pkg}/${wasm.file}`;

P2 Badge Resolve doctor WASM path from commands directory

This relative path was correct before the move, but from assistant/src/cli/commands/doctor.ts the expression ../../node_modules/... points to assistant/src/node_modules instead of assistant/node_modules. In source runs, assistant doctor will now falsely report missing Tree-sitter WASM files even when dependencies are installed, which degrades diagnostics reliability.


const candidate = join(import.meta.dir, "..", "..", "..", "skills");

P2 Badge Update dev skills catalog lookup to new file depth

With the command file moved under cli/commands, this ../../../skills lookup now resolves to assistant/skills instead of the repo-level skills/ directory. When VELLUM_DEV is enabled, getRepoSkillsDir() will miss the local catalog and disable repo-local skill discovery, which breaks local development/offline workflows for assistant skills.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@noanflaherty

Copy link
Copy Markdown
Contributor Author

Addressed in #14257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant