M1: Onboarding variant routing & First Meeting flow skeleton#1350
Merged
Conversation
Introduce OnboardingVariant enum (.default, .firstMeeting) with UserDefaults persistence and --onboarding-variant CLI arg for DEBUG builds. Fork OnboardingWindow.show() to route between the existing OnboardingFlowView and a new FirstMeetingFlowView with placeholder steps (egg, hatch, introduction, capabilities briefing, observation). Closes #1341 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91bc0ef7e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4 tasks
Contributor
Author
|
Addressed in #1363 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnboardingVariantenum (.default,.firstMeeting) toOnboardingStatewith UserDefaults persistence and restorationconversationCompleted,capabilitiesBriefingShown,observationCompleted,firstTaskCandidate--onboarding-variant first_meetingCLI arg in DEBUG buildsOnboardingWindow.show()to route betweenOnboardingFlowViewand newFirstMeetingFlowViewFirstMeetingFlowViewskeleton with placeholder steps (egg, hatch, introduction, capabilities briefing, observation mode)Part of #1340. Closes #1341.
Test plan
./clients/macos/build.sh--onboarding-variant first_meetinglaunches FirstMeetingFlowView with placeholder stepsclearPersistedState()clears variant key🤖 Generated with Claude Code