Clear suppress timer before overwrite in handleModelSet#130
Merged
Conversation
Rapid successive handleModelSet calls would overwrite the __suppress_reset__ timer in the map without cancelling the previous one. The orphaned timer would fire early, resetting suppressConfigReload to false before the latest write's file watcher event arrives, causing unexpected config reloads and session eviction. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses feedback from #127:
__suppress_reset__timer before creating a new one inhandleModelSet. Without this, rapid successive model changes would leave orphaned timers that fire early, resettingsuppressConfigReloadtofalseprematurely and causing the file watcher to trigger redundant config reloads that evict sessions.This matches the pattern already used in the file watcher debounce code (lines 121-122).
Test plan
tsc --noEmitpasses🤖 Generated with Claude Code