chore: remove dead WakeWord and Voice files#11763
Conversation
Remove 6 unused files from the Voice/WakeWord subsystem: - WakeWordErrorRecovery.swift (117 lines) — never wired into WakeWordCoordinator - WakeWordActivationIndicator.swift (193 lines) — never wired into WakeWordCoordinator - WakeWordDismissHandler.swift (109 lines) — never used by any code - WakeWordPrivacyGuard.swift (113 lines) — never wired into WakeWordCoordinator - AudioAmplitudeTracker.swift (41 lines) — zero references outside file - TTSEngine.swift (94 lines) — zero references, likely obsoleted by voice simplification These files define types that are never instantiated or referenced by WakeWordCoordinator, VoiceModeManager, or any other production code. Co-Authored-By: ashlee@vellum.ai <ashlee@vellum.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
|
Requesting review from @alex-nork (authored WakeWord files in PRs #8141/#8159) and @AnitaKirkovska (authored AudioAmplitudeTracker/TTSEngine in PR #6095) — these 6 files were never wired into WakeWordCoordinator or VoiceModeManager. |
|
@codex review |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…eWordCoordinator WakeWordActivationWindow is instantiated at WakeWordCoordinator.swift:27. The initial dead code scan missed this reference. The other 5 files (WakeWordErrorRecovery, WakeWordDismissHandler, WakeWordPrivacyGuard, AudioAmplitudeTracker, TTSEngine) remain confirmed dead. Co-Authored-By: ashlee@vellum.ai <ashlee@vellum.ai>
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
ashleeradka
deleted the
devin/1772570847-remove-dead-wakeword-voice-files
branch
1 participant
Summary
Removes 5 unused Swift files (~474 lines) from the macOS Voice/WakeWord subsystem. These files define types (
WakeWordErrorRecovery,WakeWordDismissHandler,WakeWordPrivacyGuard,AudioAmplitudeTracker,TTSEngine) that are never instantiated or referenced byWakeWordCoordinator,VoiceModeManager,AppDelegate, or any other production code.They appear to have been written as supporting infrastructure for the wake word feature but were never wired in — the coordinator uses
WakeWordFeedbackandAlwaysOnAudioMonitordirectly instead.Found as part of a broader dead code investigation in
clients/.Updates since last revision
WakeWordActivationIndicator.swift— review correctly identified thatWakeWordActivationWindowis instantiated atWakeWordCoordinator.swift:27. The initial dead code scan missed this reference. This PR now deletes 5 files instead of the original 6.Review & Testing Checklist for Human
.pbxproj) doesn't reference the deleted files. This PR only deletes source files — it does not update any Xcode project. If these are listed in the project's build sources, the build will break.WakeWordErrorRecovery,WakeWordDismissHandler,WakeWordPrivacyGuard,AudioAmplitudeTracker, andTTSEngineacross the full repo (including non-Swift files). The original scan already had one false positive (WakeWordActivationIndicator), so extra caution is warranted for the remaining deletions.TTSEnginewasn't used via a property on another object (e.g., stored as alet tts = TTSEngine()somewhere that grep might have missed in a multi-line context).Notes
AudioAmplitudeTracker,TTSEngine) were added in PR feat: voice-driven permission handling, info panel, and voice mode improvements #6095 (two-way voice mode) but likely obsoleted by the voice simplification in PR Simplify Voice Capabilities #11628.WakeWordActivationIndicator.swiftis kept becauseWakeWordCoordinatoractively uses it.