feat(voice): emit callback handoff notification on guardian-wait timeout#10930
Conversation
… callback during guardian wait When a caller explicitly opts into callback during guardian-wait and the wait ends without resolution (timeout or transport close), emit a notification signal to the guardian so the callback intent is not silently dropped. - Add emitAccessRequestCallbackHandoff() helper with idempotency guard - Trigger from handleAccessRequestTimeout() and handleTransportClosed() - Include trusted-contact member reference when resolvable - Add ingress.access_request.callback_handoff fallback copy template - Add relay-server tests for timeout/close/idempotency/member-ref coverage - Add copy-composer tests for new notification template Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@codex review |
|
@devin review |
…iteria Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
The Codex P1 feedback about restricting callback handoff member mapping to trusted contacts was already addressed in the merged code. The |
…out (#10930) * feat(voice): emit callback handoff notification when caller opts into callback during guardian wait When a caller explicitly opts into callback during guardian-wait and the wait ends without resolution (timeout or transport close), emit a notification signal to the guardian so the callback intent is not silently dropped. - Add emitAccessRequestCallbackHandoff() helper with idempotency guard - Trigger from handleAccessRequestTimeout() and handleTransportClosed() - Include trusted-contact member reference when resolvable - Add ingress.access_request.callback_handoff fallback copy template - Add relay-server tests for timeout/close/idempotency/member-ref coverage - Add copy-composer tests for new notification template Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: gate callback handoff requesterMemberId on active+allow trust criteria Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Summary
emitAccessRequestCallbackHandoff()helper with idempotency guard (in-memory flag + deterministic dedupeKey) to prevent duplicate notifications from timeout + transport-close raceingress.access_request.callback_handoffsource eventTest plan
Original prompt
/Users/noaflaherty/Repos/vellum-ai/vellum-assistant/.private/plans/voice-access-request-callback-handoff-notification-one-pr-plan-2026-03-01.md
🤖 Generated with Claude Code