fix: serialize feature-flag config writes to prevent concurrent races#10244
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
7 tasks
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #10183:
The PATCH handler for feature flags performs a read-modify-write of config.json. Without serialization, concurrent PATCH requests (e.g. toggling multiple skills quickly from UI) could race and cause last-writer-wins, silently dropping flag changes.
This adds a promise-chain serializer (
configWriteChain) that ensures each write completes before the next one begins. Input validation still runs concurrently — only the critical section (read-modify-write) is serialized.Other review items (P1 transport host, P2 token preservation, P2 local HTTP fallback, P2 dotted skill IDs) were already addressed in direct pushes to the feature branch before it merged.