Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ConfigDir Template #807

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

tobby-s
Copy link
Contributor

@tobby-s tobby-s commented Aug 17, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Go used when building/testing:

  • 1.23

How Has This Been Tested?

haven't gotten around to learning how to build and run a branch. but this is a relatively simple change that's covered in unit test cases.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@LandonTClipp LandonTClipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, I think we can merge it once the tests pass.

@tobby-s
Copy link
Contributor Author

tobby-s commented Sep 17, 2024

This looks fine, I think we can merge it once the tests pass.

Could I clarify what this means?

@LandonTClipp
Copy link
Collaborator

The tests have passed so we can merge 😃

Sorry I have not been more responsive, I'll get this done tomorrow!

@LandonTClipp LandonTClipp merged commit 6423255 into vektra:master Sep 17, 2024
4 checks passed
@tobby-s
Copy link
Contributor Author

tobby-s commented Sep 18, 2024

No worries 😅 I was just asking in case it was expected of contributors to build their branch and test, which I didn't have time for earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mock generation for non-relative-to-interface dirs
2 participants