Fails with import errors with modules on Go 1.11

[atombender]

If I have a simple file such as this that refers to an imported package:

package mypackage
import "github.com/jackc/pgx"
// ...

then it fails with:

/Users/alex/.go/pkg/mod/github.com/jackc/[email protected]+incompatible/batch.go:6:2: could not import github.com/jackc/pgx/pgproto3 (cannot find package "github.com/jackc/pgx/pgproto3" in any of:
	/usr/local/opt/go/libexec/src/github.com/jackc/pgx/pgproto3 (from $GOROOT)
	/Users/alex/.go/src/github.com/jackc/pgx/pgproto3 (from $GOPATH))

In other words, it's looking for the source in the old location, not in $GOPATH/pkg/mod.

I'm able to reproduce this in a small Go program that uses golang.org/x/tools/go/loader to load files, and I can confirm that it does not work with Go modules. (E.g. see this issue for discussion.) Apparently the golang.org/x/tools/go/loader library has been superceded by golang.org/x/tools/go/packages, which is module-aware.

[atombender]

@evanphx? This is a complete blocker on Go 1.11 with modules.

[mjlangan]

We are seeing similar errors from mockery after trying Go 1.11 with modules

Generating mock for: Adapter in file: mocks/Adapter.go
/Users/michaell/go/src/golang.org/x/crypto/ssh/terminal/util.go:20:2: could not import golang.org/x/sys/unix (cannot find package "golang.org/x/sys/unix" in any of:
    /usr/local/go/src/golang.org/x/sys/unix (from $GOROOT)
    /Users/michaell/go/src/golang.org/x/sys/unix (from $GOPATH))
/Users/michaell/go/pkg/mod/github.com/!sirupsen/[email protected]/terminal_bsd.go:6:8: could not import golang.org/x/sys/unix (cannot find package "golang.org/x/sys/unix" in any of:
    /usr/local/go/src/golang.org/x/sys/unix (from $GOROOT)
    /Users/michaell/go/src/golang.org/x/sys/unix (from $GOPATH))
...

go mod vendor does pull these dependencies into the repository's /vendor/ folder, but it appears that mockery doesn't look there for dependencies when generating mocks.

[euskadi31]

Any news ? This prevents us to use mockery. Thx !

[bliuchak]

Is there any working alternative for Go 1.11 with modules?

[euskadi31]

@bliuchak yes, I use Docker...

Dockerfile.generate

FROM golang:1.10-alpine
RUN apk --no-cache --update add git make
RUN mkdir -p /go/src/github.com/your-name/your-service
WORKDIR /go/src/github.com/your-name/your-service
RUN go get github.com/vektra/mockery/.../
CMD ["make", "inner-generate"]

Makefile

inner-generate:
	@go get ./...
	@go generate ./...

generate-builder:
	@docker build -f Dockerfile.generate -t your-service-generate .

generate: generate-builder
	@# hack for https://github.com/vektra/mockery/issues/213
	@echo "Generate..."
	@docker run --rm --name your-service-generate-running -v $(shell pwd):/go/src/github.com/your-name/your-service your-service-generate

[kasirajanss93]

It would be nice if you could add support to go mod

[glyn]

We've decided to use counterfeiter (which does support Go modules) instead of mockery in a new go modules project in spite of the fact that we've been happily using mockery in non-module code. Some of mockery's features are missed, but at least counterfeiter works. We could potentially switch back to mockery if/when this issue is fixed.

[atombender]

@evanphx?

[davisford]

Has there been a new release with PR #218? Doing standard install of mockery still has problem for me.

[atombender]

@davisford It's merged. This project doesn't do releases or tags, unfortunately, but go get -u (or cloning + go install) should get you the latest one. If you still have problems, maybe you can create a new issue, and I'll take a look.