Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "DO NOT EDIT." to generated sources as per convention #183

Closed
danielbprice opened this issue Feb 2, 2018 · 5 comments
Closed

Add "DO NOT EDIT." to generated sources as per convention #183

danielbprice opened this issue Feb 2, 2018 · 5 comments

Comments

@danielbprice
Copy link

As per golang/go#13560, golint and other tools will now skip files which are generated, assuming the files are marked as such.

mockery doesn't do this, and, at least for me, generated source fails lint.

So:

// Code generated by mockery v1.0.0

Just needs to be:

// Code generated by mockery v1.0.0. DO NOT EDIT.
whiteheadrj added a commit to whiteheadrj/mockery that referenced this issue Mar 9, 2018
@whiteheadrj
Changed auto gen message to include 'DO NOT EDIT.' to not cause lint …
57f4c1a 
…errors vektra#183
@whiteheadrj whiteheadrj mentioned this issue Mar 9, 2018
Merged
@bogdanovich
Copy link

Can we please get his merged ASAP?

@bogdanovich
Copy link

@evanphx

@maja42
Copy link

maja42 commented Jul 4, 2018

I just wanted to create the same issue. It's a bit annoying that the header is not correctly set.

@AlekSi
Copy link

AlekSi commented Sep 20, 2018

#188 was merged. @danielbprice please close this issue.

@danielbprice
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AlekSi @maja42 @danielbprice @bogdanovich