Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #231: Parsing a field type with a bang should not increase the … #236

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Fixes #231: Parsing a field type with a bang should not increase the … #236

merged 1 commit into from
Sep 9, 2022

Conversation

zmay2030
Copy link
Contributor

@zmay2030 zmay2030 commented Sep 8, 2022 •
edited
Loading

Fix #231

I added a new TestTypePosition test under schema_test.go because the current TestSchemaDocument dumps AST and ast's dumper omits Position.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 88.666% when pulling 91372b1 on Aven30:fix-231 into 88d9590 on vektah:master.

@StevenACoffman StevenACoffman merged commit eae2341 into vektah:master Sep 9, 2022
@StevenACoffman
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenACoffman StevenACoffman StevenACoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type's line number always off by one if it includes a bang
3 participants
@zmay2030 @coveralls @StevenACoffman