Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Rocky Linux 8.8-8.10 requires Python 3.11 #50

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

BenjamenMeyer
Copy link
Member

Thank you for submitting a pull request and becoming a contributor to Vega Strike's Build System Docker Images.

Please answer the following:

Code Changes:

  • This is a documentation change only
  • CI Change

Purpose:
When updating the images the Python 8.8-8.10 images were changed from Python 3.11 Devel to just Python3 Devel which meant depending on Python 3.6.

Interestingly if Python 3.6 and 3.11 are installed then CMake will lock only Python 3.6. So we have to cleanup the image so it will build correctly too.

When updating the images the Python 8.8-8.10 images were changed
from Python 3.11 Devel to just Python3 Devel which meant depending
on Python 3.6.

Interestingly if Python 3.6 and 3.11 are installed then CMake will
lock only Python 3.6. So we have to cleanup the image so it will
build correctly too.
@BenjamenMeyer BenjamenMeyer added the bug Something isn't working label Oct 12, 2024
@BenjamenMeyer BenjamenMeyer self-assigned this Oct 12, 2024
Copy link

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine trimming the versions to fewer. However, I don't know how to review the bootstrap code without going down a rabbit hole.

@@ -1734,7 +1734,7 @@ function bootstrapOnRockyLinux ()
libpng-devel \
expat-devel \
gtk3-devel \
python3-devel \
python3.11-devel \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to find out if this is the right version. Rocky doesn't have a package management site as it is based on RHEL. RHEL has one but you apparently need a login.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what we had for 8.8 originally and I mistakenly took it out. I did get it to compile once I added this back in and removed the other one as it seems cmake will find one and stop there.

Iirc there's a 3.12 too.

@BenjamenMeyer
Copy link
Member Author

I'm fine trimming the versions to fewer. However, I don't know how to review the bootstrap code without going down a rabbit hole.

That's why I added the vs-image.sh tooling. So it was easy to get into the images. I've got another little rev to it that will make the base image and report local images too. So everything can be easy setup and done with little effort. Might need to document it better though.

@BenjamenMeyer
Copy link
Member Author

Oh...and after merging we do a release to make the images for the CI system.

@BenjamenMeyer BenjamenMeyer merged commit 5562a49 into vegastrike:master Oct 14, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants