Update: change supported images #49
Conversation
| - 'opensuse/leap:15.5' | ||
| - 'opensuse/leap:15.4' | ||
| - 'opensuse/leap:15.3' | ||
| - 'opensuse/leap:15.2' | ||
| #- 'fedora:41' | ||
| - 'fedora:40' | ||
| - 'fedora:39' |
There was a problem hiding this comment.
Can we do this with a variable? Something like opensuse/leap:>15.2?
There was a problem hiding this comment.
These directly translate to Docker Image names so no we can't use comparisons, etc.
| @@ -124,16 +124,43 @@ function bootstrapOnDebian() | |||
| lsb-release | |||
| ;; | |||
| "buster") | |||
| echo "Sorry, Debian buster is no longer supported" | |||
There was a problem hiding this comment.
We can probably do an array of unsupported and a for/each.
There was a problem hiding this comment.
Its more for helping us catch what we deprecated. We can clean them up to reduce the list after a time.
We use GitHub Actions to see that the images build successfully. Generally this works fine, but when there's a major distro change we might have to rework dependencies but we won't catch that until we're using the images in the engine repo right now. Not sure we need to check that in the GHA here. I have a modified version of one of the scripts for doing local image builds to test and help diagnose failures there. I could probably add a second for running with the engine build too as a local test thing. We do want to keep the effort here relatively light. |
Add Distros
Drop Distros