Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from imp to importlib #109

Open
wants to merge 3 commits into
base: 0.9.x
Choose a base branch
from

Conversation

david-geiger
Copy link
Contributor

BenjamenMeyer and others added 3 commits January 14, 2024 14:36
…ion-update_0.10.x

UPdate Version to 0.10.x
- the 'imp' module is deprecated from years and now Python 3.12 finally
  drops completely support of 'imp' module.
- fix for vegastrike#107
Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your original PR is good to do against our master (0.10.x) branch. Please rebase this against our 0.9.x branch. Ultimately we need to do 2 PRs.

$ git checkout -b bugfix_imp-to-importlib_0.9.x
$ git rebase 0.9.x

# If it doesn't cleanly rebase the do this to resolve conflicts 
$ git mergetool
$ git rebase --continue

# when done
$ git push origin bugfix_imp-to-importlib_0.9.x
````


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants