feat: start node base on group #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlem
reviewed
May 12, 2023
karlem
reviewed
May 12, 2023
karlem
previously approved these changes
May 12, 2023
|
Merging as it has been approved previously |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/vegaprotocol/devops-infra/issues/1856 .
We cannot remove all nodes from the particular group and then start a node from it because we do not have any node available for the
--base-onflag. So I have added the--base-on-groupflag, which does not require the node in a particular group.This change adds the ability to start the node in the particular group even if no node is running.
I have tested this with the following code: vegaprotocol/devopstools#41