fix: update tooltip positioning for CSP #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Looks great. |
domoritz
reviewed
Nov 18, 2022
domoritz
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sites with Content Security Policies that do not feature the
unsafe-inlinespecification, it seems the more preferable approach for tooltip positioning is using the CSS Object Model method.style.Currently, vega-tooltip uses
setAttributeto adjust the tooltip positioning (top & left) at the same time - here. This invokes the HTML parser and CSP inline checks are triggered, blocking the operation. When the tooltip positioning is directly adjusted via.style.top&.style.left, the operations successfully comply with a CSP directive ofstyle-src: self.Some discussion/context here