Conversation
Member
|
Thank you |
dangotbanned
added a commit
to dangotbanned/altair
that referenced
this pull request
Aug 3, 2024
binste
added a commit
to vega/altair
that referenced
this pull request
Aug 4, 2024
* style: Sort `VEGA_THEMES` alphabetically * feat: Add missing `carbon...` themes Examples https://vega.github.io/vega-themes/?theme=carbonwhite Related vega/vega-themes#587 * feat(typing): Support autocomplete for `themes.enable(name)` And provide link to `vega-themes` playground * chore: Fix `PluginRegistery` comment typo * Add comments --------- Co-authored-by: Stefan Binder <binder_stefan@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻
I've updated the 4 Carbon themes to be much better-aligned with our actual implementations here https://charts.carbondesignsystem.com
The current implementation really is 2 (dark & light) themes, and does not have all the details in there.
We've also hosted the Plex font, and a CSS bundle for the theme on our official CDN, which is documented here
https://github.com/carbon-design-system/carbon-vega-theme/blob/main/README.md
We'll be working to make further enhancements to this soon.
Cheers