fix: use current branch for Resource.hash
#669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangotbanned
commented
Jan 21, 2025
domoritz
approved these changes
Jan 21, 2025
dsmedia
added a commit
that referenced
this pull request
Jan 23, 2025
Incorporates latest build_datapackage.py changes from PR #669 which improves hash calculation using local git commands uvx ruff check is run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #668 (comment)
As discovered by @dsmedia, I made a bit of an oversight in #665.
Now instead of querying the GitHub trees API, we're just using
gitdirectly.Need to merge before #668, so that the changes there can add the new hash for
us-state-capitals.json.