Skip to content

Finish transition to v2#187

Merged
domoritz merged 32 commits intomasterfrom
v2
Jun 16, 2020
Merged

Finish transition to v2#187
domoritz merged 32 commits intomasterfrom
v2

Conversation

@domoritz
Copy link
Member

@domoritz domoritz commented Jun 1, 2020

Closes #145

See changelog in the changes.

I'm going to leave this open for discussion for a bit. Please let me know if you see any issues. I will make sure that we don't cause any problems with examples in the Vega and Vega-Lite example galleries.

@domoritz domoritz changed the title V2 Finish transition to V2 Jun 1, 2020
@domoritz domoritz changed the title Finish transition to V2 Finish transition to v2 Jun 1, 2020
Copy link
Contributor

@eitanlees eitanlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eitanlees
Copy link
Contributor

Actually I am confused. The temperature data in seattle-weather-hourly.csv looks odd

visualization (4)

Is it celsius?

@domoritz
Copy link
Member Author

domoritz commented Jun 2, 2020

I just downloaded the data from NOAA. The docs are at https://www1.ncdc.noaa.gov/pub/data/cdo/documentation/NORMAL_HLY_documentation.pdf. The docs say the data has average daily minimal temperatures for 30 years ending 2010. I used metric units, yes.

Screen Shot 2020-06-02 at 10 31 38

@eitanlees
Copy link
Contributor

I support the removal of the iris dataset.

We will need to update:

once this is merged.

@domoritz
Copy link
Member Author

I published 2.0.0-beta.2 so we can start updating the examples and see if we accidentally break anything.

I started Vega-Lite updates in vega/vega-lite#6566.

My plan is to release this weekend but I wanted to give folks time to voice their opinions on the breaking changes here.

@visnup
Copy link
Contributor

visnup commented Jun 12, 2020

Penguins?! Goes to play with penguin data.

@domoritz
Copy link
Member Author

🐧 Have a look at https://github.com/allisonhorst/palmerpenguins. Feel free to post links to any visualizations you are making that we could include in the Vega-Lite example gallery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up for 2.0

5 participants