follow up for node:test pr #2419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurfiorette
requested review from
Copilot and
domoritz
and removed request for
domoritz
There was a problem hiding this comment.
Pull request overview
This PR migrates the test framework from Jest to Node.js's built-in node:test, removes Babel configuration, and reorganizes test files into dedicated folders. It also attempts to replace the glob dependency with Node.js's native fs.globSync.
Key Changes:
- Removed Jest and Babel dependencies and configuration files
- Reorganized tests into
test/valid-data,test/invalid-data,test/config, andtest/vega-litefolders - Updated test names to include category prefixes (e.g., "valid-data - ", "config - ", "invalid-data - ")
- Attempted migration from
globpackage to nativefs.globSync
Reviewed changes
Copilot reviewed 291 out of 292 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| factory/program.ts | Bug: Incorrect import of globSync from node:fs |
| test/utils.ts | Refactored test helpers into assertValidSchema, assertConfigSchema, and assertInvalidSchema functions |
| test/valid-data/**/index.test.ts | Added "valid-data - " prefix to all test names |
| test/invalid-data/**/index.test.ts | New structure: moved from single file to individual test files per case |
| test/config/**/index.test.ts | New structure: moved from single file to individual test files per config |
| test/vega-lite/vega-lite.test.ts | Moved from root test directory to dedicated folder |
| package.json | Removed glob, @babel/*, chai, jest dependencies; moved @typescript/vfs to devDependencies |
| jest.config.cjs | Deleted (no longer using Jest) |
| babel.config.cjs | Deleted (no longer using Babel) |
| eslint.config.mjs | Removed Jest globals from test file configuration |
| .vscode/settings.json | Removed Jest-specific settings |
| .prettierignore | Removed Babel and Jest config files from ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
domoritz
reviewed
Dec 1, 2025
domoritz
approved these changes
Dec 1, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globto nativefs.globSyncinvalid-data,configandvega-litetests to its own folders/files📦 Published PR as canary version:
2.4.1--canary.2419.6ef894b.0✨ Test out this PR locally via:
Version
Published prerelease version:
v2.5.0-next.15Changelog
🎉 This release contains work from new contributors! 🎉
Thanks for all your work!
❤️ Sam Sudar (@srsudar)
❤️ Orta Therox (@orta)
❤️ James Vaughan (@jamesbvaughan)
❤️ Alex (@alexchexes)
❤️ Cal (@CalLavicka)
❤️ Valentyne Stigloher (@pixunil)
🚀 Enhancement
NewExpressionparser #2346 (@jamesbvaughan)🐛 Bug Fix
--additional-propertiesoption #2305 (@alexchexes)--type "*"is used with multiple exports #2284 (@alexchexes @arthurfiorette)symbol#2282 (@alexchexes)🔩 Dependency Updates
Authors: 9