Skip to content

fix: type issues with Chart save methods. #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattijn merged 3 commits into from
Jan 7, 2026
+10 −10
Merged

fix: type issues with Chart save methods. #3934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6aed6d9
Fix unknown dict type issues.
alec-bike Dec 30, 2025
3e68cf1
Ignore some type errors in save.
alec-bike Dec 30, 2025
404eca0
Revert typing as None over Undefined.
alec-bike Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions altair/utils/save.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@


def write_file_or_filename(
fp: str | Path | IO,
fp: str | Path | IO[Any],
content: str | bytes,
mode: str = "w",
encoding: str | None = None,
Expand All @@ -30,7 +30,7 @@ def write_file_or_filename(


def set_inspect_format_argument(
format: str | None, fp: str | Path | IO, inline: bool
format: str | None, fp: str | Path | IO[Any], inline: bool
) -> str:
"""Inspect the format argument in the save function."""
if format is None:
Expand Down Expand Up @@ -78,7 +78,7 @@ def set_inspect_mode_argument(
def _save_mimebundle_format(
spec: dict[str, Any],
format: Literal["html", "png", "svg", "pdf", "vega"],
fp: str | Path | IO,
fp: str | Path | IO[Any],
inner_mode: Literal["vega-lite"],
vega_version: str | None,
vegalite_version: str | None,
Expand Down Expand Up @@ -170,14 +170,14 @@ def _save_mimebundle_format(

def save(
chart,
fp: str | Path | IO,
fp: str | Path | IO[Any],
vega_version: str | None,
vegaembed_version: str | None,
format: Literal["json", "html", "png", "svg", "pdf", "vega"] | None = None,
mode: Literal["vega-lite"] | None = None,
vegalite_version: str | None = None,
embed_options: dict | None = None,
json_kwds: dict | None = None,
embed_options: dict[str, Any] | None = None,
json_kwds: dict[str, Any] | None = None,
scale_factor: float = 1,
engine: Literal["vl-convert"] | None = None,
inline: bool = False,
Expand Down Expand Up @@ -235,7 +235,7 @@ def save(

json_kwds = json_kwds or {}
encoding = kwargs.get("encoding", "utf-8")
format = set_inspect_format_argument(format, fp, inline) # type: ignore[assignment]
format = set_inspect_format_argument(format, fp, inline) # type: ignore

def perform_save() -> None:
spec = chart.to_dict(context={"pre_transform": False})
Expand Down
6 changes: 3 additions & 3 deletions altair/vegalite/v6/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2321,16 +2321,16 @@ def open_editor(self, *, fullscreen: bool = False, validate: bool = True) -> Non

def save(
self,
fp: str | Path | IO,
fp: str | Path | IO[Any],
format: Literal["json", "html", "png", "svg", "pdf"] | None = None,
override_data_transformer: bool = True,
scale_factor: float = 1.0,
mode: str | None = None,
vegalite_version: str = VEGALITE_VERSION,
vega_version: str = VEGA_VERSION,
vegaembed_version: str = VEGAEMBED_VERSION,
embed_options: dict | None = None,
json_kwds: dict | None = None,
embed_options: dict[str, Any] | None = None,
json_kwds: dict[str, Any] | None = None,
engine: str | None = None,
inline: bool = False,
**kwargs: Any,
Expand Down