docs: Unstack area to render cumulative chart correctly#3890
Closed
joelostblom wants to merge 2 commits intomainfrom
Closed
docs: Unstack area to render cumulative chart correctly#3890joelostblom wants to merge 2 commits intomainfrom
joelostblom wants to merge 2 commits intomainfrom
Conversation
Contributor
|
I noticed I resolved this differently in #3859. Can you check what is currently in the main branch in the doc folder here if the fix I applied is appropriate? I followed the spec from the corresponding Vega-lite page: https://vega.github.io/vega-lite/docs/window.html. |
Contributor
Author
|
That looks fine too, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We forgot this location when updating the gallery example in #3558.