refactor: Remove channels parameter in infer_encoding_types#3564
Merged
refactor: Remove channels parameter in infer_encoding_types#3564
channels parameter in infer_encoding_types#3564Conversation
Removes the dependency in `test_infer_encoding_types`
Was kept, but only needed for tests since vega#3444. As `infer_encoding_types` is not public API - this is a safe remove, no need for deprecation
dangotbanned
requested review from
binste and
mattijn
and removed request for
mattijn
binste
approved these changes
Sep 4, 2024
Contributor
binste
left a comment
binste
left a comment
There was a problem hiding this comment.
LGTM! Agree that monkey patching is a better way of handling this instaed of having code in Altair which is only used in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was kept, but only needed for tests since #3444.
This PR factors out the test dependency, by using
pytest.MonkeyPatch- to temporarily replace the global cache.As
alt.utils.core.infer_encoding_typesis not public API - this is a safe remove, no need for deprecation.