feat(typing): Generate Literal aliases in channels overload(s)#3535
Merged
feat(typing): Generate Literal aliases in channels overload(s)#3535
Literal aliases in channels overload(s)#3535Conversation
binste
approved these changes
Aug 13, 2024
Contributor
binste
left a comment
binste
left a comment
There was a problem hiding this comment.
I really like that you keep reducing the file sizes significantly! Apart from overall readability, it also reduces the size of the wheel file which is nice for pyodide. Altair 5.3.0 was 850KB and 5.4.0 only 650KB :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
Literalaliases #3469Literalaliases inapi#3464ruffrules, improve type annotations, improve ci performance #3431Description
Discovered this while working on a larger refactoring to support #3519 (comment) in #3536
This change alone though is very minor, but has a nice -6k to lines of code