Skip to content

Comments

fix: remove remapped ruff rule PLR1701#3453

Merged
mattijn merged 1 commit intovega:mainfrom
dangotbanned:fix-ruff-warning
Jun 30, 2024
Merged

fix: remove remapped ruff rule PLR1701#3453
mattijn merged 1 commit intovega:mainfrom
dangotbanned:fix-ruff-warning

Conversation

@dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Jun 30, 2024

Fixes warnings here https://github.com/vega/altair/actions/runs/9733301918/job/26860053484?pr=3452

This was due to ruff updating around the same time as #3431 (comment)
The SIM101 rule that it is remapped to is already part of our config

Fixes https://github.com/vega/altair/actions/runs/9733301918/job/26860053484?pr=3452

This was due to `ruff` updating around the same time as vega#3431 (comment)
The `SIM` rule that it  is remapped to is already part of our config
@mattijn mattijn merged commit 3bea543 into vega:main Jun 30, 2024
@mattijn
Copy link
Contributor

mattijn commented Jun 30, 2024

Thanks @dangotbanned!

@dangotbanned dangotbanned deleted the fix-ruff-warning branch June 30, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants