Skip to content

doc: barchart highlighting values beyond a single threshold#3249

Merged
mattijn merged 2 commits intomainfrom
highlight-beyond-single-threshold
Nov 6, 2023
Merged

doc: barchart highlighting values beyond a single threshold#3249
mattijn merged 2 commits intomainfrom
highlight-beyond-single-threshold

Conversation

@mattijn
Copy link
Contributor

@mattijn mattijn commented Nov 4, 2023

This PR fix #2996.

There is still a bit of discussion how to introduce a barchart with multiple thresholds, see #3227, but I think we now have an example-worthy method for a barchart highlighting values beyond a single threshold.

@mattijn mattijn requested a review from binste November 4, 2023 20:03
Copy link
Contributor

@binste binste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mattijn ! Could you align all quotation marks to the same style (I prefer double quotations but we're not consistent with it in the docs)? Apart from that, LGTM.

@mattijn
Copy link
Contributor Author

mattijn commented Nov 6, 2023

Thanks for the review @binste! Modified as requested. Merging.

@mattijn mattijn merged commit 18ce6fb into main Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add VL example 'Bar Chart Highlighting Values beyond a Threshold' to gallery

2 participants