Add missing arguments to Parameter and add type hints#3173
Merged
Conversation
joelostblom
approved these changes
Sep 21, 2023
Contributor
joelostblom
left a comment
There was a problem hiding this comment.
Thank you @binste ! I am not very familiar with type but this looks harmless, so approving to avoid it going stale. Feel free to merge.
Contributor
Author
|
Thanks @joelostblom :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in #3143 that
alt.paramsets some attributes onalt.Parameterwhich do not exist on that class when its initialised. That's a problem for mypy as all attributes should exist from the beginning. This PR addsempty,param, andparam_typeand type hints for the whole class.I tested with the Interval examples from the docs to make sure that indeed
empty=Undefinedleads toemptynot being present in the final chart dict which is the old behaviour whenemptywas not present on the parameter instance at all if it was not defined.