Type hints: Add static type checker mypy#2950
Merged
mattijn merged 10 commits intovega:masterfrom Mar 17, 2023
Merged
Conversation
…is expected due to _PropertySetter
Contributor
|
Thanks for this PR @binste! Eg Dict[str, Any] | NoneInstead of Optional[Dict[str, Any]] |
Contributor
Author
|
Unfortunately no. The pipe operator throws a SyntaxError prior to 3.10, see https://mypy.readthedocs.io/en/stable/runtime_troubles.html#using-x-y-syntax-for-unions. This can be circumvented by doing the "Future Annotations Import" |
Contributor
|
That's unfortunate. It would improve readability of the type definitions. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds mypy as a linter and fixes all current errors. This is a prerequisite for the subsequent tasks outlined in #2951.