exclude altair_saver in build.yml as Github Actions tests are not passing anymore#2893
Merged
mattijn merged 1 commit intoFeb 18, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
altair_saverin currently not maintained and its status is fragile. Since npm 9 has become default in Github Actions our tests are not passing anymore. See also altair-viz/altair_saver#113 & altair-viz/altair_saver#116.Luckily
vl-convert(docs) is running already parallel toaltair_saverin our Github Actions as it is a near complete alternative.This PR comment out the part where
altair_saveris used within Github Actions in thebuild.ymluntilaltair_saveris getting maintenance support again.