Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory cache updates may trigger an error about BagshuiHiddenTooltip #102

Closed
veechs opened this issue Mar 1, 2025 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@veechs
Copy link
Owner

veechs commented Mar 1, 2025

Describe the bug

Under certain circumstances, an inventory cache update may raise the error:

Interface\FrameXML\GameTooltip.lua:101: BagshuiHiddenTooltipMoneyFrame:SetPoint(): Couldn't find region named `BagshuiHiddenTooltipTextLeft31'

To reproduce

Visit a repair NPC and click Repair All.

Expected behavior

No error.

Screenshots

No response

Environment

Bagshui Version: 1.4.2
Game Version: 1.17.2 7206 Dec 21 2024

Addons

SuperWoW: 1.5

Enabled:

  • [SuperWoW] Tank Plates 1.3.2 1.3.2
  • [K] LazyPig 6.0.5
  • Add On Organizer
  • aux
  • Bagshui 1.4.2
  • BetterCharacterStats 1.13.0 1.13.0
  • BonusScanner
  • CT_MailMod 1.44 (CTMod 1.856)
  • HCWarn 6
  • HealComm
  • Interact by luskanek GIT
  • NotGrid -Ace2-
  • Outfitter
  • SuperAPI -balake-
  • Tmog -Spit- 2.9
  • ShaguCombat 0.1 DEVEL
  • ShaguPlates 5.4.14
  • ShaguTweaks GIT
  • ShaguTweaks-mods GIT
  • Файна Українська
Disabled:
  • Atlas TurtleWOW 1.13.7
  • AtlasLoot TurtleWOW 3.0.9
  • GroupFinder
  • pfDebug 0.1
  • pfQuest GIT
  • pfQuest [TurtleWoW DB] GIT
  • ShaguJunk 1.0
  • ShaguKill 1.0
  • Pepopo Big Wigs 30110 Turtle-WoW 2.0.0
  • ShaguScan 1.0

Additional context

Reported via Discord PM. Still trying to reproduce.

@veechs veechs added the bug Something isn't working label Mar 1, 2025
veechs added a commit that referenced this issue Mar 1, 2025
Another attempt at fixing #102
@veechs veechs changed the title Repairing gear may trigger a strange BagshuiHiddenTooltip error Visiting a repair NPC or selling items may trigger an error about BagshuiHiddenTooltip Mar 1, 2025
@veechs
Copy link
Owner Author

veechs commented Mar 1, 2025

From what I can tell, this seems to occur when the tooltip somehow has too many lines and then money information is added. The workaround is to just set the OnTooltipAddMoney script handler to nothing since we don't (currently) need the money info..

@veechs veechs changed the title Visiting a repair NPC or selling items may trigger an error about BagshuiHiddenTooltip Inventory cache updates may trigger an error about BagshuiHiddenTooltip Mar 1, 2025
veechs added a commit that referenced this issue Mar 1, 2025
Was previously (unnecessarily) an empty function.
Final fix for #102.
veechs added a commit that referenced this issue Mar 1, 2025
@veechs veechs closed this as completed in 30a03e1 Mar 1, 2025
@veechs veechs self-assigned this Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant