Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new div is created every time date selected (date-range) + selection (inuse class) not removed when using clear button #457

Closed
lenamtl opened this issue Apr 4, 2018 · 12 comments
Labels

Comments

@lenamtl
Copy link

lenamtl commented Apr 4, 2018

I'd like to know if this is normal and the reason why these div are created.

I'm using date range uxsolutions/bootstrap-datepicker
and external filters
occurred in several browser

Every time I select a date
a new div is created, this is visible through the console

To reproduce select a from or to date and check in console
<div id="yadcf-filter-wrapper--13_4"></div>

see console results
2018-04-04_11-39-25

this seems similar to this #68

@vedmack
Copy link
Owner

vedmack commented Apr 4, 2018

thanks, its a bug, please provide a simple test case so I will be able to fix it sooner

@vedmack vedmack added the bug label Apr 4, 2018
@lenamtl
Copy link
Author

lenamtl commented May 2, 2018

Do you know what create this and how to fix it?

@vedmack
Copy link
Owner

vedmack commented May 2, 2018 via email

@lenamtl
Copy link
Author

lenamtl commented May 3, 2018

I think this bug should be fix as it may bring other issues probably the random issue I got with loclastorage.

As You already fix the problem for range see #68
I thought it will not be long for you to fix this one too,

I will really appreciate...

@vedmack
Copy link
Owner

vedmack commented May 7, 2018

@lenamtl , please provide a simple test case page

@lenamtl
Copy link
Author

lenamtl commented May 7, 2018

Hi,
I'm not able to create a jsfiddle...
I have tried a few time but I cannot link Yadcf beta file as it is not in CDN
I have tried to link the raw version from Github with no luck.

Anyway you should be able to reproduce easily
I'm using externally_triggered: true
date range uxsolutions/bootstrap-datepicker

I have 4 filters that are select2 and only one with date range

On page load an extra div the one of the date_range (is duplicated) appear just before the ending span
(check image I provided previous message)
<div id="yadcf-filter-wrapper--13_4"></div>

*If I select a date in calendar it is creating one extra div
**If i enter the date manually it is creating one extra div for each digit or each keyboard key I hit this is very bad

@vedmack
Copy link
Owner

vedmack commented May 7, 2018

look at the following video to see how to get link of the raw file from github (hosted on rawgit "cdn")
https://giphy.com/gifs/2tM7uZjm3w8W5NNmQn/html5

@lenamtl
Copy link
Author

lenamtl commented May 7, 2018

Thanks for the info.

Here is the JSfiddle
https://jsfiddle.net/lenamtl/124aussb/21/

@vedmack vedmack changed the title Possible bug : new div is created every time I select a date (date-range) new div is created every time date selected (date-range) + selection (inuse class) not removed when using clear button May 8, 2018
vedmack added a commit that referenced this issue May 8, 2018
@vedmack
Copy link
Owner

vedmack commented May 8, 2018

fixed

@vedmack vedmack closed this as completed May 8, 2018
@lenamtl
Copy link
Author

lenamtl commented May 9, 2018

Thanks a lot

@lenamtl
Copy link
Author

lenamtl commented Jun 8, 2018

?

@vedmack
Copy link
Owner

vedmack commented Jun 8, 2018

@lenamtl hhhhhh.... No freaking idea how that was sent from my account...I mean I do have a clue, but still...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants