Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in column_inner_data_helper, related to #424 #426

Closed
JeroenvO opened this issue Dec 17, 2017 · 0 comments
Closed

Bug in column_inner_data_helper, related to #424 #426

JeroenvO opened this issue Dec 17, 2017 · 0 comments
Labels

Comments

@JeroenvO
Copy link
Contributor

Thanks for the nice fix on #424, I did some more testing and found a little bug in your code, after processing a row with multiple html-matches, the col_inner_data_helper gets populated (correctly), but it is not reset after processing the row. In the next table-row the check on line https://github.com/vedmack/yadcf/blob/master/src/jquery.dataTables.yadcf.js#L2315 fails if that next row doesn't have multiple elements.

Possible fix: set col_inner_data_helper=null between line 2327 and 2328

@vedmack vedmack added the bug label Dec 21, 2017
SebastianRoland added a commit to SebastianRoland/yadcf that referenced this issue Feb 14, 2018
* commit 'c549c9295d508af5d4b7eb398796f6f9a0a645a2':
  Fix a markdown link in readme ✌️
  Added support for col reorder in range filters - vedmack#429
  bug fix: vedmack#426
  bug fix: vedmack#425
  enhancement for parsing multiple html elements in cell
  0.9.3 beta has began...
  yadcf 0.9.2 goes final
  fixed filter_type: 'text' with FixedHeader
  Add CSS class on DateRange fields

# Conflicts:
#	src/jquery.dataTables.yadcf.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants