Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

column_data_type html doesn't fallback to text #422

Closed
JeroenvO opened this issue Dec 2, 2017 · 5 comments
Closed

column_data_type html doesn't fallback to text #422

JeroenvO opened this issue Dec 2, 2017 · 5 comments
Labels

Comments

@JeroenvO
Copy link
Contributor

JeroenvO commented Dec 2, 2017

When column_data_type is set to 'html', and (some) cells do not contain sub-html-elements, the contents is discarded. This is due to the $(..) on line https://github.com/vedmack/yadcf/blob/master/src/jquery.dataTables.yadcf.js#L2288. The $(..) returns an empty string when a plain text input is given.

Suggested fix: change line https://github.com/KolibriSolutions/yadcf/blob/master/src/jquery.dataTables.yadcf.js#L2332, to take the originall cell content instead of col_inner_elements

@JeroenvO
Copy link
Contributor Author

JeroenvO commented Dec 3, 2017

Related to issue #96, as the selector property is used which is no longer in the latest jquery version

@vedmack
Copy link
Owner

vedmack commented Dec 4, 2017

please provide a jsfiddle test page so I check / test it

@JeroenvO
Copy link
Contributor Author

JeroenvO commented Dec 4, 2017

Ok

See https://api.jquery.com/selector/ for the deprication notice.

i found around 90 usages of .selector in your code. I don't know if they all refer to the depricated jquery property, but anyway it will require a large rewrite to fix make everything compatible with the latest jquery.

@vedmack vedmack added the bug label Dec 5, 2017
vedmack added a commit that referenced this issue Dec 5, 2017
@vedmack
Copy link
Owner

vedmack commented Dec 5, 2017

fixed, here is a working jsfildde

@vedmack vedmack closed this as completed Dec 5, 2017
@JeroenvO
Copy link
Contributor Author

JeroenvO commented Dec 5, 2017

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants