-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy template field #322
Conversation
@agileware-pengyi just very superficially - the description makes me think you would be REMOVING code but you are adding a lot - which makes me wonder why... Perhaps screenshots would help |
@eileenmcnaughton the removed line reusing this file. I replaced the line with its content and remove the template field. So the field will not be displayed in Mosaico editor. |
ok so looking at this the concept of the PR makes 100% sense to me, the way the PR has been done doesn't 100% make as much sense to me but that is ok. Just verballing out there are possibly other options we could pursuse
@totten @eileenmcnaughton @agileware-pengyi i'm not sure what is overall the best option here but my thinking would be 1 would be the most simple to do and possibly have the best results overall for any future template builder (may not necessairly be Mosacio). |
1 seems Ok to me - but I'm less familiar with this code |
I would prefer 1 if the traditional templates won't be used on any other editors. |
I would assume that traditional templates wouldn't be used at all going forward for newer editiors. I would appreciate @totten weighing in as well |
Agree, it's really nice how In the long-term, it might be ideal for |
@agileware-pengyi - Just want to say - for someone coming in new to Angular, it looks like a good start. 👍 I know more feedback here becomes moot when changing to
All of these files are basically the same, except that they remix the various UI elements in different layouts. The current set of directives ( The change here (hiding one item from There is a good argument that maybe the contract for these directives ( That allows all of the wonky field-markup to be defined one time ( |
Just noting that alternative PR has been submitted here civicrm/civicrm-core#14927 |
The legacy mailing template is not used in Mosaico template, however, the field is shown when editing Moscaico mailing without shoreditch. This cause users to confuse.
Before
Legacy template field in the form.
After
Legacy template field removed from the form.
Comment
Feel free to improve this PR since I am not familiar with Angular.
Agileware ref: CIVIMOSAIC-18