Ai-fitness-coach - #3
Closed
benfrank241 wants to merge 4 commits into
Closed
Conversation
Collaborator
|
please open PR to https://github.com/vectorize-io/hindsight-cookbook |
nicoloboschi
added a commit
that referenced
this pull request
Feb 6, 2026
…raction 1. Groq gpt-oss-120b doesn't support response_format (structured output) - Returns 400 'json_validate_failed' error - Retries with exponential backoff caused 300s timeout - Skip test #3 (structured output) for this model 2. Reinforce date extraction prompt - Add CRITICAL instruction to extract absolute dates like 'March 15, 2024' - Helps prevent flaky test_extract_facts_with_absolute_dates failures
nicoloboschi
added a commit
that referenced
this pull request
Feb 6, 2026
* fix: resolve flaky test failures in api tests Fixed 4 critical test failures that revealed real production issues: 1. test_sensory_dimension_preservation: Updated fact extraction prompt to clarify that sensory/emotional details ARE important to remember even if they seem small. The "6 months" filter was too aggressive and causing LLM to skip valid observations. 2. test_llm_provider_api_methods[openai-gpt-5]: Increased max_completion_tokens from 200 to 500 for tool calling tests. Non-nano models like gpt-5 were hitting token limits before completing tool calls. 3. test_reflect_chinese_content: Added prominent anti-hallucination warnings to reflect agent prompts. LLM was making up names (张飞, 张三, 赵信) instead of using the actual names from retrieved facts (张伟, 李明). Added explicit instructions at the very top of system prompts to NEVER fabricate names and to use EXACT names from retrieved data. 4. test_llm_provider_api_methods[groq-openai/gpt-oss-120b]: Skipped this model in tests as it consistently times out (>120s) due to slow Groq API responses. All changes address real production code issues, not test flakiness. * refactor: simplify anti-hallucination prompts and document groq issue - Removed verbose anti-hallucination section with emojis/borders - Moved core anti-hallucination rules to top of system prompts in clean format - Kept essential rules: NEVER make up names/entities, ONLY use tool results - Removed language override rule (directives can control language) - Removed specific example (too prescriptive) Groq gpt-oss-120b: - Documented that API hangs on receive_response_body (Groq API bug) - Skip is justified: headers received successfully but body never arrives - This is gpt-oss-120b specific, not a general Groq provider issue * fix: remove groq skip as requested - Groq gpt-oss-120b may be slow but should not be skipped - test_extensions.py::test_reflect_pre_hook_receives_all_parameters passes locally (50s) - CI timeout appears to be from LLM producing malformed tool names (done<|channel|>commentary) which triggers retries and slows down the test * fix: ensure unique timestamps for facts across different documents The time offset logic was resetting to 0 for each new content_index, causing all facts from different documents/conversations to have the same base timestamp even when they should be distinguishable. Changed to use absolute position (i) instead of relative position (i - content_fact_start) so that: - Content 0, Fact 0: offset = 0s - Content 0, Fact 1: offset = 10s - Content 1, Fact 0: offset = 20s (now unique!) - Content 1, Fact 1: offset = 30s This ensures facts from different batch-retained documents have unique timestamps for proper temporal ordering in retrieval. Fixes test_fact_ordering.py::test_multiple_documents_ordering * fix: increase timeout for test_llm_provider_api_methods to 300s The groq gpt-oss-120b model can be very slow (API hangs on response body), taking >120s to complete. Increased timeout to 300s to prevent CI flakiness while still catching real hangs. This affects all provider/model combinations in the test, not just Groq, but most complete in <30s so the increased timeout won't affect them. * fix: skip structured output for groq gpt-oss-120b, reinforce date extraction 1. Groq gpt-oss-120b doesn't support response_format (structured output) - Returns 400 'json_validate_failed' error - Retries with exponential backoff caused 300s timeout - Skip test #3 (structured output) for this model 2. Reinforce date extraction prompt - Add CRITICAL instruction to extract absolute dates like 'March 15, 2024' - Helps prevent flaky test_extract_facts_with_absolute_dates failures
DK09876
added a commit
that referenced
this pull request
Mar 19, 2026
- Fix #2: Add per-bank asyncio.Lock to _ensure_bank for concurrency safety - Fix #3: Clamp search score to max(0.0, ...) to prevent negative values - Fix #4: Implement suffix matching in _handle_list_namespaces - Fix #5: Truncate namespaces to max_depth instead of filtering (per BaseStore contract) - Fix #6: Remove list_namespaces/alist_namespaces overrides — let base class handle prefix=/suffix= kwargs - Fix #7: Document ephemeral namespace tracking and get() limitations in class docstring - Fix #8: Add stable ID to recall node SystemMessage, document ordering behavior - Fix #9: Change budget/max_tokens/recall_tags_match defaults to None so global config fallback works - Fix #10: Conditionally populate __all__ so import * works without langgraph installed - Fix #11: Bump langgraph lower bound from >=0.3.0 to >=0.5.0 - Fix #12: Extract _resolve_client to shared _client.py module Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nicoloboschi
pushed a commit
that referenced
this pull request
Mar 20, 2026
* feat: add LangGraph integration with tools, nodes, and store patterns Add hindsight-langgraph SDK providing three integration patterns: - Tools: retain/recall/reflect as LangChain tools for ReAct agents - Nodes: automatic memory injection and storage as graph steps - Store: LangGraph BaseStore implementation for checkpoint-based memory Fix: remove `from __future__ import annotations` in nodes.py which prevented LangGraph from passing RunnableConfig to node functions (runtime type inspection saw string annotations instead of actual types). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: register langgraph with independent versioning system - Set version to 0.1.0 (integrations are versioned independently) - Add langgraph to VALID_INTEGRATIONS in release-integration.sh - Add changelog page for langgraph integration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: remove manual cookbook recipe page The sync-cookbook script will auto-generate this from the notebook in hindsight-cookbook once PR #17 is merged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: comprehensive improvements to langgraph integration Code fixes: - Retain node only stores latest messages instead of all history (prevents duplicates) - Handle multimodal msg.content (list type) in nodes - Fix store docstring separator "/" → "." - Apply search filters before pagination in store - Add ttl parameter to store.aput for LangGraph BaseStore compat - Fix _ensure_bank to not cache failed bank creations - Fix falsy value bugs (or → is not None) in tools - Remove from __future__ import annotations from all files - Consistent default budget="mid" across tools/nodes/store - Bump langgraph floor to >=0.3.0, remove duplicate dev deps Docs fixes: - Fix broken Cloud client example (base_url is required) - Complete API reference tables with all parameters - Add Limitations and Notes section (async-only store, etc.) - Add Requirements section - Fix broken cookbook link and Cloud claim in blog post All 61 unit tests pass. E2E tested against Hindsight Cloud: tools, nodes, store, configure(), multimodal content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: remove blog post (lives in hindsight-marketing-content) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: remove Hindsight Cloud section from langgraph docs Keep OSS docs self-hosted-first, consistent with other integration docs (crewai, pydantic-ai, agno). Cloud setup details live in the cookbook notebooks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: explicitly mention LangChain compatibility in langgraph integration The tools pattern (create_hindsight_tools) only depends on langchain-core and works with plain LangChain via bind_tools() — no LangGraph required. Update docs to make this clear with both LangGraph and LangChain quick start examples. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: address PR review findings 1. Guard manual test files with if __name__ == "__main__" so pytest doesn't collect and execute them during test runs 2. Remove semantic fallback in HindsightStore.aget() — only return exact document_id matches, not unrelated semantic search hits 3. Make langgraph an optional dependency — tools pattern only needs langchain-core. Install with pip install hindsight-langgraph[langgraph] for nodes and store patterns. Lazy imports with clear error messages. 4. Clean up README to be self-hosted-first, consistent with other integration docs 5. Update docs requirements section to reflect optional langgraph dep Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: address PR review feedback for langgraph integration - Fix #2: Add per-bank asyncio.Lock to _ensure_bank for concurrency safety - Fix #3: Clamp search score to max(0.0, ...) to prevent negative values - Fix #4: Implement suffix matching in _handle_list_namespaces - Fix #5: Truncate namespaces to max_depth instead of filtering (per BaseStore contract) - Fix #6: Remove list_namespaces/alist_namespaces overrides — let base class handle prefix=/suffix= kwargs - Fix #7: Document ephemeral namespace tracking and get() limitations in class docstring - Fix #8: Add stable ID to recall node SystemMessage, document ordering behavior - Fix #9: Change budget/max_tokens/recall_tags_match defaults to None so global config fallback works - Fix #10: Conditionally populate __all__ so import * works without langgraph installed - Fix #11: Bump langgraph lower bound from >=0.3.0 to >=0.5.0 - Fix #12: Extract _resolve_client to shared _client.py module Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: address remaining review gaps for langgraph integration - Add output_key parameter to create_recall_node for prompt ordering control - Add prefix/suffix/combined filter tests for list_namespaces - Add output_key unit tests (memory text, none on empty, none on error) - Remove unused imports and backward-compat alias in tools.py - Update docs with output_key usage example and API reference Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: relax langgraph version constraint to >=0.3.0 Research confirmed all required APIs (BaseStore, SearchItem, Result, GetOp, PutOp, SearchOp, ListNamespacesOp) are available since langgraph-checkpoint 2.0.7, which maps to langgraph >=0.2.63. Using >=0.3.0 as a clean semver boundary — >=0.5.0 was unnecessarily conservative and excluded many compatible versions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
This was referenced Jul 10, 2026
nepenth
pushed a commit
to nepenth/hindsight
that referenced
this pull request
Aug 7, 2026
- Fix vectorize-io#2: Add per-bank asyncio.Lock to _ensure_bank for concurrency safety - Fix vectorize-io#3: Clamp search score to max(0.0, ...) to prevent negative values - Fix vectorize-io#4: Implement suffix matching in _handle_list_namespaces - Fix vectorize-io#5: Truncate namespaces to max_depth instead of filtering (per BaseStore contract) - Fix vectorize-io#6: Remove list_namespaces/alist_namespaces overrides — let base class handle prefix=/suffix= kwargs - Fix #7: Document ephemeral namespace tracking and get() limitations in class docstring - Fix vectorize-io#8: Add stable ID to recall node SystemMessage, document ordering behavior - Fix vectorize-io#9: Change budget/max_tokens/recall_tags_match defaults to None so global config fallback works - Fix vectorize-io#10: Conditionally populate __all__ so import * works without langgraph installed - Fix vectorize-io#11: Bump langgraph lower bound from >=0.3.0 to >=0.5.0 - Fix vectorize-io#12: Extract _resolve_client to shared _client.py module Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nepenth
pushed a commit
to nepenth/hindsight
that referenced
this pull request
Aug 7, 2026
…raction 1. Groq gpt-oss-120b doesn't support response_format (structured output) - Returns 400 'json_validate_failed' error - Retries with exponential backoff caused 300s timeout - Skip test vectorize-io#3 (structured output) for this model 2. Reinforce date extraction prompt - Add CRITICAL instruction to extract absolute dates like 'March 15, 2024' - Helps prevent flaky test_extract_facts_with_absolute_dates failures
nepenth
pushed a commit
to nepenth/hindsight
that referenced
this pull request
Aug 7, 2026
- Fix vectorize-io#2: Add per-bank asyncio.Lock to _ensure_bank for concurrency safety - Fix vectorize-io#3: Clamp search score to max(0.0, ...) to prevent negative values - Fix vectorize-io#4: Implement suffix matching in _handle_list_namespaces - Fix vectorize-io#5: Truncate namespaces to max_depth instead of filtering (per BaseStore contract) - Fix vectorize-io#6: Remove list_namespaces/alist_namespaces overrides — let base class handle prefix=/suffix= kwargs - Fix #7: Document ephemeral namespace tracking and get() limitations in class docstring - Fix vectorize-io#8: Add stable ID to recall node SystemMessage, document ordering behavior - Fix vectorize-io#9: Change budget/max_tokens/recall_tags_match defaults to None so global config fallback works - Fix vectorize-io#10: Conditionally populate __all__ so import * works without langgraph installed - Fix vectorize-io#11: Bump langgraph lower bound from >=0.3.0 to >=0.5.0 - Fix vectorize-io#12: Extract _resolve_client to shared _client.py module Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nepenth
pushed a commit
to nepenth/hindsight
that referenced
this pull request
Aug 7, 2026
…raction 1. Groq gpt-oss-120b doesn't support response_format (structured output) - Returns 400 'json_validate_failed' error - Retries with exponential backoff caused 300s timeout - Skip test vectorize-io#3 (structured output) for this model 2. Reinforce date extraction prompt - Add CRITICAL instruction to extract absolute dates like 'March 15, 2024' - Helps prevent flaky test_extract_facts_with_absolute_dates failures
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.